-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS focussed CLI implementation for Shareable Viz #1661
Conversation
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: mehdinv <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Mistakenly wrote 'kedro run' instead of 'kedro viz' - commit changes it to be the latter Co-authored-by: Merel Theisen <[email protected]>
Signed-off-by: mehdinv <[email protected]>
Signed-off-by: mehdinv <[email protected]>
Signed-off-by: mehdinv <[email protected]>
Signed-off-by: mehdinv <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
into feature/cli-share-viz Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Thanks @ravi-kumar-pilla
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 I was wondering though why several of the logging messages are now info
instead of debug
?
@@ -63,7 +63,7 @@ def _ingest_heap_analytics(self): | |||
env = Environment(loader=FileSystemLoader(_HTML_DIR)) | |||
|
|||
if should_add_telemetry: | |||
logger.debug("Ingesting heap analytics.") | |||
logger.info("Ingesting heap analytics.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a info message?
Co-authored-by: Merel Theisen <[email protected]>
Release 7.0.0 Major features and improvements Upgrade to React 18. (Migrate to React 18 #1652) Change CLI command to run Kedro-viz tokedro viz run. (Change 'Kedro Viz' to 'Kedro Viz Run' #1671) Add deploy command to the CLI using kedro viz deploy for sharing Kedro-viz on AWS. (AWS focussed CLI implementation for Shareable Viz #1661) Add support for kedro==0.19and kedro-datasets==2.0. (Fix bug on kedro viz --load-file #1677) Drop support for python=3.7. (Remove support for Python 3.7 #1660) Drop support for kedro==0.17.x. (Drop Kedro 17 #1669) Bug fixes and other changes Fix modular pipelines breaking when collapsed on the flowchart. (Fix modular pipelines breaking when collapsed. #1651) Display hosted URL in CLI while launching Kedro viz. (Display hosted URL in CLI while launching kedro viz #1644) Fix Kedro-viz display on Jupyter notebooks. (Fix Kedro-viz embedded as an IFrame #1658) Fix zoom issues on the flowchart. (Flowchart doesn't automatically reset the zoom when actions are performed. #1672) Fix bug on kedro-viz run --load-file. (Fix bug on kedro viz --load-file #1677) Fix bug on adding timestamps to shareable-viz. (_#1679)
Description
Resolves #1636
Development notes
kedro viz deploy
as a deploy command for shareable viz focussing on AWSQA notes
pip install -e package
cd demo-project
kedro viz deploy
Checklist
RELEASE.md
file