Remove GraphQL subscription #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tynan DeBold <[email protected]>
tynandebold
requested review from
rashidakanchwala,
jitu5 and
ravi-kumar-pilla
5 tasks
|
thanks for this. Can we also please remove the related tests on BE and if any on FE. |
rashidakanchwala
approved these changes
Oct 5, 2023
Signed-off-by: Tynan DeBold <[email protected]>
tynandebold
changed the title
Signed-off-by: Tynan DeBold <[email protected]>
Signed-off-by: Tynan DeBold <[email protected]>
…moved Signed-off-by: ravi-kumar-pilla <[email protected]>
tynandebold
deleted the
chore/remove-graphql-subscription-from-frontend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the GraphQL subscription from experiment tracking. This feature was added because it seemed like it would benefit users. We've never heard anyone mention they like this feature, and it causes some annoyances when deploying Viz statically, so we're removing it.
Development notes
The relevant parts of code have been removed.
QA notes
Experiment should still work exactly the same. The only difference would be if you were running a Viz process and then did a
kedro run, your experiment tracking page wouldn't live reload.Checklist
RELEASE.mdfile