Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to search for a '<lambda' Python function in the sidebar #1497

Merged
merged 7 commits into from
Aug 23, 2023

Conversation

jitu5
Copy link
Contributor

@jitu5 jitu5 commented Aug 21, 2023

Description

Resolves #854

Searching for lambda or partial functions in the sidebar doesn't work when including the < or > character, as those interfere with either the search matching or element rendering.

QA notes

After this PR if your search query contains "<" or ">" it list result with correct highlighting. As show below.
Screenshot 2023-08-21 at 1 34 54 p m

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@jitu5 jitu5 requested a review from tynandebold as a code owner August 21, 2023 12:39
@jitu5 jitu5 self-assigned this Aug 21, 2023
@jitu5 jitu5 requested a review from yetudada as a code owner August 21, 2023 12:39
@jitu5 jitu5 marked this pull request as draft August 21, 2023 13:17
@jitu5 jitu5 marked this pull request as ready for review August 21, 2023 13:58
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty cool! :) thanks @jitu5

Copy link
Member

@tynandebold tynandebold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works perfectly!

src/utils/index.js Outdated Show resolved Hide resolved
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💯

@tynandebold tynandebold merged commit db17134 into main Aug 23, 2023
@tynandebold tynandebold deleted the fix/lambda_function_search branch August 23, 2023 12:12
vladimir-mck pushed a commit that referenced this pull request Aug 29, 2023
* Fix to search for a '<lambda' Python function in the sidebar

* Fix for failed test cases

* Variable name updated

---------

Co-authored-by: Tynan DeBold <[email protected]>
Signed-off-by: Vladimir <[email protected]>
vladimir-mck pushed a commit that referenced this pull request Aug 29, 2023
* Fix to search for a '<lambda' Python function in the sidebar

* Fix for failed test cases

* Variable name updated

---------

Co-authored-by: Tynan DeBold <[email protected]>
Signed-off-by: Vladimir <[email protected]>
vladimir-mck pushed a commit that referenced this pull request Aug 30, 2023
* Fix to search for a '<lambda' Python function in the sidebar

* Fix for failed test cases

* Variable name updated

---------

Co-authored-by: Tynan DeBold <[email protected]>
Signed-off-by: Vladimir <[email protected]>
@rashidakanchwala rashidakanchwala mentioned this pull request Aug 31, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to search for a <lambda Python function in the sidebar
5 participants