Fix button for large pipeline warning #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rashida Kanchwala <[email protected]>
tynandebold
reviewed
Jun 30, 2023
| @@ -35,7 +35,6 @@ $secondary-underline-offset-hover: 4px; | |||
| box-shadow: none; | |||
| color: var(--color-button__text); | |||
| cursor: pointer; | |||
| display: flex; | |||
There was a problem hiding this comment.
We need this, otherwise it alters the Apply changes and close button:
Signed-off-by: Rashida Kanchwala <[email protected]>
Huongg
reviewed
Jun 30, 2023
| <Button mode="secondary" onClick={onDisable} size="small"> | ||
| Don't show this again | ||
| </Button> | ||
| <div className="pipeline-warning__button-wrapper"> |
There was a problem hiding this comment.
hey @rashidakanchwala Do we not need any styling for this new classname ?
There was a problem hiding this comment.
nope, this div basically ensures that the buttons are not next to each other ... just followed this way (https://github.com/kedro-org/kedro-viz/blob/main/src/components/settings-modal/settings-modal.js#L149)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is to fix this issue
Development notes
This bug was introduced due to changes on this ticket - #875 where display:flex is being added here. I have removed it for now. Removing this hasn't affected the Apply/Close buttons but @tynandebold can confirm.