Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch general exeception when git fails #1380

Merged
merged 6 commits into from
Jun 9, 2023
Merged

Catch general exeception when git fails #1380

merged 6 commits into from
Jun 9, 2023

Conversation

noklam
Copy link
Contributor

@noklam noklam commented Jun 5, 2023 •
edited by tynandebold
Loading

Description

Following kedro-org/kedro#1826

Fixes #1291

Development notes

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@noklam noklam marked this pull request as ready for review June 6, 2023 12:14
@noklam noklam requested a review from rashidakanchwala as a code owner June 6, 2023 12:14
@noklam noklam requested a review from tynandebold June 7, 2023 20:14
@tynandebold
Copy link
Member

How can I test this?

@noklam
Copy link
Contributor Author

noklam commented Jun 8, 2023 •
edited
Loading

  1. git checkout remotes/origin/main - Reproducing the same error when git is on a detach HEAD
  2. cd demo-project
  3. kedro run - Type Error
  4. git checkout remotes/origin/fix-git-exception
  5. kedro run - should run without issues

@tynandebold

tynandebold
tynandebold approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@tynandebold tynandebold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, looks good and works well.

@tynandebold
Copy link
Member

Please add a line to the release notes for this as well!

@noklam noklam requested a review from yetudada as a code owner June 8, 2023 15:25
rashidakanchwala
rashidakanchwala approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@rashidakanchwala rashidakanchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Nok. works well.

Maybe we can remove the ImportError exception now. and return only the one you wrote.

rashidakanchwala
rashidakanchwala reviewed Jun 8, 2023
View reviewed changes
RELEASE.md Outdated

# Release 6.2.1

## Major features and improvements

- Add support for new kedro-viz layer configuration in kedro-datasets. (#1373)
- Show original node input and output names in metadata panel. (#1381)
- Fix bug where git causing kedro-viz panic. (#1380)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this goes in bugs and fixes. but maybe we can move that in the release ticket.

@tynandebold tynandebold merged commit ca3d4f4 into main Jun 9, 2023
@tynandebold tynandebold deleted the fix-git-exception branch June 9, 2023 09:20
@tynandebold tynandebold mentioned this pull request Jun 9, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rashidakanchwala rashidakanchwala rashidakanchwala approved these changes

@tynandebold tynandebold tynandebold approved these changes

@yetudada yetudada Awaiting requested review from yetudada

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Experiment tracking raising an issue in GitHub action
3 participants
@noklam @tynandebold @rashidakanchwala