-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Research: Viz usage as a React component #954
Comments
On 5 July, 2022, the following question was posed to the appropriate users channels in Discord and Slack:
After ~48 hours, we have:
It's also thought that these two products might be using Viz as a React component:
Next step: follow up with each positive (yes) response, plus the two products linked above, and as them about how they're using Viz. Specifically:
|
@tynandebold Thank you for tagging me! I am not using Viz as a React component, I just used the Viz pipeline image in my website (sorry for the confusion...) |
No confusion! Thank you for clarifying :) |
Thanks for pushing this @tynandebold I have a couple of thoughts on this. In my eyes, much of the value of Viz has been providing largely back-end facing engineers with the ability to communicate to state/function/purpose of their data engineering / science efforts to non-technical audiences. I think there is potential to strive further in this direction.
In my own experience this medium article was a fun but painful experience to prepare. I had to work closely with @studioswong to find a way of compiling Viz as a SPA so that I could embed a version of the flowchart and also disable the sidebar behaviour. In my eyes, it should be simple to just say Viz component + JSON = Visualization. With this in mind, where do I see real potential for this direction? DOCS I think there are many places where a user may want to share a sub-graph of their pipeline and annotate / describe the purpose embedded in their docs. The Python world uses Sphinx as the primary documentation generator and this provides a plugin entrypoint where we could a native way of adding a Kedro Viz widget within the docs. There Mermaid plugin feels like a good analogue for what we would need to do this properly, although I think shorter routes to MVP will exist. |
Great context @datajoely, thank you. Some thoughts and questions:
|
Hi folks - nice discussion! joining in the fun with my 2 cents here. @tynandebold to your second and third point, my understanding is that @datajoely wants to showcase the interactive kedro-viz pipeline using medium embeds via a glitch hosted link (see this article). I had a brief look at embedding and rendering an html file as an embed in medium and don't think Medium supports it natively - i.e doing so will still require you to upload and host the html file somewhere which is probably the same amount of effort as setting it up as a react component export. My curiosity is - what is the reason to not support the react component usage? It might seem counter-intuitive to look into setting up a new function to export and output a standalone HTML file in kedro-viz rather than utilizing the npm export setup which we have already setup nicely within our CI pipeline. There are other QB products who are consuming kedro-viz via npm ( such as Brix) - does stopping the npm support means they won't get the new goodies from latest versions of kedro-viz? In terms of the the user request from #638 , to me it seems like a different use case as it looks like the user just wants a fast way to export svg/png directly via the terminal rather than via the Kedro-Viz UI, which is an entire different use case from those who consumes kedro-viz via an npm component ( which most likely they utilize it to showcase the interactive flowchart) |
|
|
@studioswong thanks for chiming in!
The short answer is to reduce complexity of the app in tandem with reducing the workload when building some potential future features.
No, we still want to support other teams using Viz while trying to determine if the way they're using it is most optimal. For the Brix case and their setup, there was no other way to use it, so they took what we offered and ran with that. Yet what if there was a more suitable alternative (e.g. a HTML-generated view of the pipeline, a Kedro-Viz-Lite NPM package only showing the flowchart, a more rich static image export, etc., etc.)? Would that have been preferable? This are some of the things we're trying to answer. |
Re 1 - As a novice JS user my understanding of 3 (Codepen) thought this wasn't valid. |
You can basically import anything from NPM into CodePen. Here's a small React app running in there. I've tried using Viz in here and unfortunately we get an error with one of our dependencies. If we didn't, it should work just fine. |
Given the feedback from user interviews, we'll continue to support using Viz as a React component. We should strive to better our user's experiences with things like modularity, being lighter weight, adding access to click handlers, and more. |
Closing this issue as the conclusion was reached that we'll still support this use case. |
Description
We'd like to know how many users are using Viz as a React component.
Context
Do we need to continue supporting this use case?
Outcome
An answer to the question above.
Checklist
The text was updated successfully, but these errors were encountered: