Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Export shows no modal #890

Closed
1 task done
tynandebold opened this issue Jun 8, 2022 · 0 comments · Fixed by #898
Closed
1 task done

Run Export shows no modal #890

tynandebold opened this issue Jun 8, 2022 · 0 comments · Fixed by #898
Assignees

Comments

@tynandebold
Copy link
Member

Description

On the experiment tracking page, after clicking export, users have no feedback to their action. This does not follow the proposed design. We should make use of the modal interaction/selection as seen on the reference link. This is the same pattern we use on the pipeline side, when users try to download the pipeline graph.

Screenshot 2022-05-24 at 11 40 1

Acceptance criteria

  • After clicking on the export icon, user is presented with our standard “export modal”
  • User can make the selection between Export all and close and Cancel.
  • After clicking on any of the options the modal closes.
  • Another way of leaving the modal is to click anywhere in the background outside the modal.

image 1

Reference link: https://zpl.io/2G3Gvp3

Checklist

  • Include labels so that we can categorise your issue
@tynandebold tynandebold moved this to Todo in Kedro-Viz Jun 8, 2022
@Huongg Huongg self-assigned this Jun 8, 2022
@Huongg Huongg moved this from Todo to In Progress in Kedro-Viz Jun 8, 2022
@Huongg Huongg moved this from In Progress to In Review in Kedro-Viz Jun 9, 2022
Repository owner moved this from In Review to Done in Kedro-Viz Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants