Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to search for a <lambda Python function in the sidebar #854

Closed
1 task done
tynandebold opened this issue May 18, 2022 · 1 comment · Fixed by #1497
Closed
1 task done

Unable to search for a <lambda Python function in the sidebar #854

tynandebold opened this issue May 18, 2022 · 1 comment · Fixed by #1497
Assignees

Comments

@tynandebold
Copy link
Member

Description

Searching for lambda or partial functions in the sidebar doesn't work when including the < or > character, as those interfere with either the search matching or element rendering.

Steps to Reproduce

  1. On the main branch, open demo-project/src/demo_project/pipelines/data_ingestion/pipeline.py
  2. Add a lambda function, like this:
node(
    func=lambda x: x,
    inputs='x',
    outputs='y'
)
  1. Search for <lamb in the sidebar search input

Expected Result

A search result should appear with blue text highlighting the matching search.

Actual Result

Nothing appears.

image

Note the lambda python functions don't render nicely on the flowchart. That'll be fixed in #851, and once fixed, this is the actual result:

image

Your Environment

Include as many relevant details as possible about the environment you experienced the bug in:

  • Web browser system and version: Chrome latest
  • Operating system and version: Mac Monterey
  • NodeJS version used (if relevant): 14
  • Kedro version used (if relevant): 4.5.0
  • Python version used (if relevant):

Checklist

  • Include labels so that we can categorise your issue
@tynandebold
Copy link
Member Author

The solve here is probably to just drop <> all together from lambda and partial functions. More context here.

@tynandebold tynandebold moved this from Inbox to Backlog in Kedro-Viz May 30, 2022
@tynandebold tynandebold moved this from Backlog to Todo in Kedro-Viz Aug 7, 2023
@jitu5 jitu5 self-assigned this Aug 16, 2023
@NeroOkwa NeroOkwa moved this from Todo to In Progress in Kedro-Viz Aug 18, 2023
@jitu5 jitu5 moved this from In Progress to In Review in Kedro-Viz Aug 21, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro-Viz Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants