Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KED-3034] If a dataset is prefixed with the word 'params' it is treated as a parameter and only shows on the expanded view #621

Closed
datajoely opened this issue Nov 9, 2021 · 1 comment · Fixed by #707

Comments

@datajoely
Copy link
Contributor

Description

As users start to experiment with the new tracking.JSONDataSet they may name their catalog entries something like params_random_forest and Kedro Viz will currently mistakenly count them as a parameter type node when they are in fact a regular data node.

Steps to Reproduce

  1. Name a dataset something prefixed with 'params'
  2. Visualise

Expected Result

Should appear as a data node like the 'hyperparams_linear` node below

Actual Result

image

Node only visible in the expanded parameter view - also impossible that a parameter should be an output to a node

@studioswong
Copy link
Contributor

good one @datajoely , let's pop this into our backlog 👍

@limdauto limdauto changed the title If a dataset is prefixed with the word 'params' it is treated as a parameter and only shows on the expanded view [KED-3034] If a dataset is prefixed with the word 'params' it is treated as a parameter and only shows on the expanded view Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants