-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kedro Viz Lite User Warnings #2058
Comments
Hi @rashidakanchwala and @stephkaiser , Based on our discussion last week about the CLI message for missing dependencies in Current message displays as - [08/23/24 16:33:59] WARNING Kedro-Viz has mocked the following data_loader.py:173
dependencies for lite-mode.
['sklearn.base', 'matplotlib.pyplot',
'matplotlib', 'seaborn', 'PIL',
'sklearn.model_selection', 'sklearn',
'sklearn.metrics']
In order to get a complete experience of Viz,
please install the missing Kedro project
dependencies Should the updated message be - [08/23/24 16:33:59] WARNING In order to get a complete experience of Kedro-Viz, data_loader.py:173
please install the missing Kedro project dependencies below:
['sklearn.base', 'matplotlib.pyplot',
'matplotlib', 'seaborn', 'PIL',
'sklearn.model_selection', 'sklearn',
'sklearn.metrics'] Thank you |
I'd suggest:
let me know what you think @rashidakanchwala |
Designs for the warning banners can be found here - https://www.figma.com/design/3kSpvIO1veLKfy9qHxuXwF/Kedro-WIP?node-id=2550-103078 Let me know what you think about the information provided. The 'Learn more' button can link to documentation with more information about missing dependencies. |
The design looks great to me. thanks @stephkaiser |
Description
This ticket is to address next steps in #1966
FE notice with a warning of missing imports
suggestion from TD on Lightweight Kedro Viz implementationCLI showing a warning message with missing imports
(already implemented but needs confirmation from design on the wording. @stephkaiser )MemoryDataset to custom ImportErrorDataset in-case of missing dataset dependencies in the metadata panel
. Since the focus is mostly on flowchart, I am not sure if we should create a custom dataset or leave this as MemoryDataset. (need to discuss this during backlog grooming)Context
We mocked missing dependencies in Kedro project when users run
kedro viz --lite
. This ticket aims at letting the users aware of the mocked dependencies both in UI and CLIPossible Implementation
In UI, have a hidden banner or something similar to this website and Kedro theme
Leave the MemoryDataset as-is or implement a custom dataset and discuss on what all functionalities to include in the dataset (mostly leaving the bare-minimum) to show up in metadata panel
Checklist
The text was updated successfully, but these errors were encountered: