Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate MetricsDataSet #1836

Closed
astrojuanlu opened this issue May 22, 2023 · 5 comments
Closed

Consolidate MetricsDataSet #1836

astrojuanlu opened this issue May 22, 2023 · 5 comments

Comments

@astrojuanlu
Copy link
Member

Description

In principle defining MetricsDataSet on kedro-viz would make some sense for now, but ultimately experiment tracking should be consumable by tools other than kedro-viz and so I don't think this would make sense longer term. More practically, it would be a huge breaking change and almost definitely not worth the cost for a small benefit. So I'd rather that we solve the underlying issue by defining what MetricsDataSet._load should do and keep it in kedro-datasets instead.

Originally posted by @antonymilne in #1352 (comment)

Context

A user (and myself) were baffled at the current monkeypatching behavior, which took a full day of debugging for an unexperienced eye to diagnose. See discussion at #1352

@antonymilne
Copy link
Contributor

N.B. this will need a few big decisions about how experiment tracking works to be made first - see my point two in #1217. The future of these datasets isn't clear to anyone I think, and so we shouldn't add any functionality to them unless they are destined to stay.

@astrojuanlu
Copy link
Member Author

Another internal user just asked about this as well https://quantumblack.slack.com/archives/C7JTFSFUY/p1685549279866579

@astrojuanlu astrojuanlu transferred this issue from kedro-org/kedro Nov 25, 2023
@merelcht
Copy link
Member

Do we still want to do something about MetricsDataset or leave it as is for now as the role of experiment tracking is also still undecided?

@astrojuanlu
Copy link
Member Author

I think we should move it to Kedro Viz. We have mentioned this possibility somewhere already.

@merelcht merelcht transferred this issue from kedro-org/kedro-plugins Mar 28, 2024
@Huongg Huongg moved this to Inbox in Kedro-Viz Jul 15, 2024
@rashidakanchwala
Copy link
Contributor

We can close this ticket as the original problem #1352 has been resolved in this PR #1698

@github-project-automation github-project-automation bot moved this from Inbox to Done in Kedro-Viz Jul 29, 2024
@astrojuanlu astrojuanlu closed this as not planned Won't fix, can't repro, duplicate, stale Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants