Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Kedro-Viz from CircleCI to GitHub Actions #1785

Closed
NeroOkwa opened this issue Mar 4, 2024 · 2 comments · Fixed by #1846 or #1876
Closed

Migrate Kedro-Viz from CircleCI to GitHub Actions #1785

NeroOkwa opened this issue Mar 4, 2024 · 2 comments · Fixed by #1846 or #1876

Comments

@NeroOkwa
Copy link
Contributor

NeroOkwa commented Mar 4, 2024

Description

We should migrate the Kedro-Viz workflow from CircleCI to GitHub Actions (GHA).

Currently, kedro, kedro-plugins and kedro-starters are all on GHA. It was covered in #2153, #176.

Kedro-Viz CircleCI setup.

Context

This would simply the Kedro-Viz CI/CD and release process, and make it concurrent with Kedro.

Possible Implementation

The workflow would include the following steps:

  • Move npm and pypi release process to GHA.
  • Move tests to GHA.
  • Nightly build.
  • Remove the CircleCI setup.
@ravi-kumar-pilla
Copy link
Contributor

Hi Team,

This is awesome ! Happy to see we are switching to GitHub Actions soon !! I would like to add few observations with our current CircleCI setup for the release -

  1. We follow a release process as mentioned here which is nice.
  2. Context: During Release, there is a github action for tagging the release and a CircleCI job for running tests (lint, unit, e2e) and publishing the package to npm, pypi.
  3. We run all the above jobs in parallel which means even if the tests fail for some reason, we still tag our release and publish it to npm, pypi. I would like to propose a flow where we have a github action which runs all the required tests (lint, unit, e2e) -> tags the release -> releases it to pypi and npm in a sequence.

Happy to discuss further when this ticket is implemented.

Thank you

@ankatiyar
Copy link
Contributor

@ravi-kumar-pilla I think that is doable, that's how we've implemented the release process on kedro and kedro-plugins
https://github.com/kedro-org/kedro/wiki/The-CI-Setup:-GitHub-Actions#the-release-setup

@jitu5 jitu5 moved this from Todo to In Progress in Kedro-Viz Mar 20, 2024
@astrojuanlu astrojuanlu moved this from In Progress to In Review in Kedro-Viz Apr 12, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro-Viz Apr 22, 2024
@rashidakanchwala rashidakanchwala moved this from Done to In Progress in Kedro-Viz Apr 29, 2024
@jitu5 jitu5 moved this from In Progress to In Review in Kedro-Viz May 2, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro-Viz May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment