-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/improvement for kedro viz build
#1717
Comments
i was able to replicate this issue at my end. I also tried to do |
also love the idea of customisable file name when doing build. |
@rashidakanchwala please provide more context how the refactored dataset code solves this issue. |
This PR seems to solve this issue: #1700 It would be good to know what exactly in the PR has fixed this. |
Before the refactor, we overroad the
In the refactored version, we separated kedro-viz and kedro-datasets, transferring all relevant logic to kedro-datasets. Now, in the mentioned cases, kedro viz run functions properly, but the preview feature is unavailable instead of causing kedro-viz to break. |
Description
Short description of the problem here.
Steps to reproduce:
kedro new
- select kedro-viz and example pipelinekedro viz build
- get errorThis may not be obvious to an user what's going on. The key to resolve this is to run
kedro run
first because the data doesn't exist yet.This also create a secondary problem - your CI need to include a
kedro run
which is a bigger ask because your CI don't necessary have access to your data i.e. S3 etc if you are just running unit tests.Minor comments
In additional, it would be nice if the target directory is customisable, I can think of use cases that people need to deploy in a special directory. they can always move files manually with commands like
mv
in the CI but it's just simpler to have it in the CLI.-- Separate them if you have more than one.
The text was updated successfully, but these errors were encountered: