Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate a single CSS file for Kedro-Viz npm lib #1512

Closed
vladimir-mck opened this issue Aug 31, 2023 · 0 comments
Closed

Generate a single CSS file for Kedro-Viz npm lib #1512

vladimir-mck opened this issue Aug 31, 2023 · 0 comments
Assignees
Labels
Javascript Pull requests that update Javascript code

Comments

@vladimir-mck
Copy link
Contributor

Description

The objective of this ticket is to enhance our development process by optimizing CSS handling and organization. The key tasks involve upgrading our webpack configuration and build scripts to seamlessly generate a single CSS file for our npm library. Furthermore, we should transition from importing individual CSS files into components and instead import SCSS files directly.

Context

At the moment in local development we engage in a redundant process of converting SCSS files into CSS files for component-level imports. This step is not needed since React Scripts can work with scss files out of the box and running the build command will parse it and bundle into a css file for us.

Additionally the npm lib has a lot of css files shipped with it. Each file is imported into it's respective component which is also unnecessary as it should ship with only 1 css file.

Outcome of this ticket

  • Replace css imports with scss imports
  • Update webpack config and scripts to bundle the scss files into a single css file for npm lib
@vladimir-mck vladimir-mck moved this to In Progress in Kedro-Viz Aug 31, 2023
@vladimir-mck vladimir-mck self-assigned this Aug 31, 2023
@tynandebold tynandebold added the Javascript Pull requests that update Javascript code label Sep 4, 2023
@vladimir-mck vladimir-mck moved this from In Progress to In Review in Kedro-Viz Sep 7, 2023
@vladimir-mck vladimir-mck moved this from In Review to Done in Kedro-Viz Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Javascript Pull requests that update Javascript code
Projects
Status: Done
Development

No branches or pull requests

2 participants