From ed927445ab9b1fde92ac922dcc6d5aa3e963700b Mon Sep 17 00:00:00 2001
From: Jitendra Gundaniya <jitendra_gundaniya@mckinsey.com>
Date: Tue, 9 Apr 2024 13:33:56 +0100
Subject: [PATCH] matrix for js removed

---
 .github/workflows/all-checks.yml                |  7 -------
 .github/workflows/javascript-lint-and-tests.yml | 17 ++++++-----------
 2 files changed, 6 insertions(+), 18 deletions(-)

diff --git a/.github/workflows/all-checks.yml b/.github/workflows/all-checks.yml
index b47ed8f3a2..4c981d6c8b 100644
--- a/.github/workflows/all-checks.yml
+++ b/.github/workflows/all-checks.yml
@@ -41,11 +41,4 @@ jobs:
       python-version: ${{ matrix.python-version }}  
       
   javascript_lint_and_tests:
-    strategy:
-      matrix:
-        os: [ ubuntu-latest ]
-        python-version: [ "3.9" ]
     uses: ./.github/workflows/javascript-lint-and-tests.yml
-    with:
-      os: ${{ matrix.os }}
-      python-version: ${{ matrix.python-version }}  
diff --git a/.github/workflows/javascript-lint-and-tests.yml b/.github/workflows/javascript-lint-and-tests.yml
index 70245689e5..74d34a356a 100644
--- a/.github/workflows/javascript-lint-and-tests.yml
+++ b/.github/workflows/javascript-lint-and-tests.yml
@@ -1,32 +1,27 @@
 name: Run javascript linters and tests on Kedro-Viz
 # Runs JavaScript linting, unit tests, and end-to-end tests on 
-# Kedro-Viz for different operating systems and Python versions.
+# Kedro-Viz for ubuntu-latest operating systems and Python 3.9.
 
 on:
   workflow_call:
-    inputs:
-      os:
-        type: string
-      python-version:
-        type: string
+
 jobs:
     javascript_lint_and_tests:
-        runs-on: ${{ inputs.os }}
+        runs-on: ubuntu-latest
         steps:
           - name: Checkout code
             uses: actions/checkout@v4
 
-          - name: Set up Python ${{inputs.python-version}}
+          - name: Set up Python "3.9"
             uses: actions/setup-python@v5
             with:
-              python-version: ${{inputs.python-version}}          
+              python-version: "3.9"          
 
           - name: Cache python packages for Linux
-            if: inputs.os == 'ubuntu-latest'
             uses: actions/cache@v4
             with:
               path: ~/.cache/pip
-              key: ${{inputs.os}}-python-${{inputs.python-version}}            
+              key: ubuntu-latest-python-3.9            
 
           - name: Install Kedro and other Python Dependencies
             uses: "./.github/actions/install_python_dependencies"