Fix broken URL when active pipeline name changes on initial load (#1914)

Remove params check to update activePipeline
kedro-org · May 22, 2024 · 3132840 · 3132840
1 parent 5a7b2af
commit 3132840
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 4 deletions.
diff --git a/RELEASE.md b/RELEASE.md
@@ -20,6 +20,7 @@ Please follow the established format:
 - Remove default props from functional components. (#1906)
 - Fix for schema change in strawberry-graphql JSON scalar. (#1903)
 - Fix messaging level when package compatibility is not satisfied. (#1904)
+- Fix broken URL when active pipeline name changes on initial load. (#1914)
 
 # Release 9.0.0
 

diff --git a/package/kedro_viz/data_access/repositories/catalog.py b/package/kedro_viz/data_access/repositories/catalog.py
@@ -12,7 +12,7 @@
     from kedro.pipeline._transcoding import TRANSCODING_SEPARATOR, _strip_transcoding
 except ImportError:  # pragma: no cover
     # older versions
-    from kedro.pipeline.pipeline import TRANSCODING_SEPARATOR, _strip_transcoding
+    from kedro.pipeline.pipeline import TRANSCODING_SEPARATOR, _strip_transcoding  # type: ignore
 
 from packaging.version import parse
 

diff --git a/package/kedro_viz/integrations/kedro/hooks.py b/package/kedro_viz/integrations/kedro/hooks.py
@@ -17,7 +17,10 @@
     from kedro.pipeline._transcoding import TRANSCODING_SEPARATOR, _strip_transcoding
 except ImportError:  # pragma: no cover
     # older versions
-    from kedro.pipeline.pipeline import TRANSCODING_SEPARATOR, _strip_transcoding
+    from kedro.pipeline.pipeline import (  # type: ignore
+        TRANSCODING_SEPARATOR,
+        _strip_transcoding,
+    )
 
 logger = logging.getLogger(__name__)
 

diff --git a/package/kedro_viz/models/flowchart.py b/package/kedro_viz/models/flowchart.py
@@ -17,7 +17,7 @@
     from kedro.pipeline._transcoding import TRANSCODING_SEPARATOR, _strip_transcoding
 except ImportError:  # pragma: no cover
     # older versions
-    from kedro.pipeline.pipeline import TRANSCODING_SEPARATOR, _strip_transcoding
+    from kedro.pipeline.pipeline import TRANSCODING_SEPARATOR, _strip_transcoding  # type: ignore
 
 from pydantic import (
     BaseModel,

diff --git a/src/components/flowchart-wrapper/flowchart-wrapper.js b/src/components/flowchart-wrapper/flowchart-wrapper.js
@@ -92,7 +92,7 @@ export const FlowChartWrapper = ({
     if (localStorageParams) {
       const paramActions = {
         pipeline: (value) => {
-          if (!searchParams.has(params.pipeline) && activePipeline) {
+          if (activePipeline) {
             toSetQueryParam(params.pipeline, value.active || activePipeline);
           }
         },