Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kedro-datasets optional dependencies requirements naming #212

Merged
merged 14 commits into from
Apr 15, 2024
Merged

Update kedro-datasets optional dependencies requirements naming #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b3de849
Update kedro-datasets optional requirements naming
lrcouto Feb 28, 2024
0df5492
Merge branch 'main' into normalize-kedro-datasets-naming
lrcouto Apr 3, 2024
95c0c58
Merge branch 'main' of github.com:kedro-org/kedro-starters into norma…
lrcouto Apr 4, 2024
b41646e
Merge branch 'normalize-kedro-datasets-naming' of github.com:kedro-or…
lrcouto Apr 11, 2024
6aad220
Rename nodes in pyspark starters
lrcouto Apr 11, 2024
41220c0
Restore old datasets naming convention for python < 3.9
lrcouto Apr 11, 2024
556960c
Rename shuttles node
lrcouto Apr 11, 2024
c2975e2
Try pin kedro-datasets to 3.0 for python 3.9+
merelcht Apr 12, 2024
256c954
Rolled back to old datasets naming
ElenaKhaustova Apr 12, 2024
5cc4943
test pulling starters from this branch
lrcouto Apr 12, 2024
14b775c
Point back to main kedro branch on test requirements
lrcouto Apr 12, 2024
654d8c8
Updated datasets's names to keep using transcoding
ElenaKhaustova Apr 15, 2024
5020347
Point to test branch to ensure tests passing
ElenaKhaustova Apr 15, 2024
5a4e821
Point back to main kedro branch
ElenaKhaustova Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion astro-airflow-iris/{{ cookiecutter.repo_name }}/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ ipython>=8.10
jupyterlab>=3.0
notebook
kedro~={{ cookiecutter.kedro_version }}
kedro-datasets[pandas.CSVDataset]>=1.0
kedro-datasets[pandas-csvdataset]>=3.0; python_version >= "3.9"
kedro-datasets[pandas.CSVDataset]>=1.0; python_version < "3.9"
kedro-airflow~=0.5
kedro-telemetry>=0.3.1
pytest-cov~=3.0
Expand Down
2 changes: 1 addition & 1 deletion features/environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ def before_scenario(context, scenario):
"install",
"-U",
# pip==23.3 breaks dependency resolution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment still relevant?

"pip==23.2",
"pip==23.3.1",
],
env=context.env,
)
Expand Down
3 changes: 2 additions & 1 deletion spaceflights-pandas-viz/{{ cookiecutter.repo_name }}/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ ipython>=8.10
jupyterlab>=3.0
notebook
kedro~={{ cookiecutter.kedro_version }}
kedro-datasets[pandas.CSVDataset, pandas.ExcelDataset, pandas.ParquetDataset, plotly.PlotlyDataset, plotly.JSONDataset, matplotlib.MatplotlibWriter]>=1.0
kedro-datasets[pandas-csvdataset, pandas-exceldataset, pandas-parquetdataset, plotly-plotlydataset, plotly-jsondataset, matplotlib-matplotlibwriter]>=3.0; python_version >= "3.9"
kedro-datasets[pandas.CSVDataset, pandas.ExcelDataset, pandas.ParquetDataset, plotly.PlotlyDataset, plotly.JSONDataset, matplotlib.MatplotlibWriter]>=1.0; python_version < "3.9"
kedro-telemetry>=0.3.1
kedro-viz>=6.7.0
pytest-cov~=3.0
Expand Down
3 changes: 2 additions & 1 deletion spaceflights-pandas/{{ cookiecutter.repo_name }}/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ ipython>=8.10
jupyterlab>=3.0
notebook
kedro~={{ cookiecutter.kedro_version }}
kedro-datasets[pandas.CSVDataset, pandas.ExcelDataset, pandas.ParquetDataset]>=1.0
kedro-datasets[pandas-csvdataset, pandas-exceldataset, pandas-parquetdataset]>=3.0; python_version >= "3.9"
kedro-datasets[pandas.CSVDataset, pandas.ExcelDataset, pandas.ParquetDataset]>=1.0; python_version < "3.9"
kedro-telemetry>=0.3.1
kedro-viz>=6.7.0
pytest-cov~=3.0
Expand Down
2 changes: 1 addition & 1 deletion spaceflights-pyspark-viz/{{ cookiecutter.repo_name }}/conf/base/catalog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ reviews:
header: True
mode: overwrite

shuttles@excel:
shuttles_excel:
type: pandas.ExcelDataset
filepath: data/01_raw/shuttles.xlsx

Expand Down
3 changes: 2 additions & 1 deletion spaceflights-pyspark-viz/{{ cookiecutter.repo_name }}/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ ipython>=8.10
jupyterlab>=3.0
notebook
kedro~={{ cookiecutter.kedro_version }}
kedro-datasets[pandas.CSVDataset, pandas.ExcelDataset, pandas.ParquetDataset, spark.SparkDataset, plotly.PlotlyDataset, plotly.JSONDataset, matplotlib.MatplotlibWriter]>=1.0
kedro-datasets[pandas-csvdataset, pandas-exceldataset, pandas-parquetdataset, spark-sparkdataset, plotly-plotlydataset, plotly-jsondataset, matplotlib-matplotlibwriter]>=3.0; python_version >= "3.9"
kedro-datasets[pandas.CSVDataset, pandas.ExcelDataset, pandas.ParquetDataset, spark.SparkDataset, plotly.PlotlyDataset, plotly.JSONDataset, matplotlib.MatplotlibWriter]>=1.0; python_version < "3.9"
kedro-telemetry>=0.3.1
kedro-viz>=6.7.0
pytest-cov~=3.0
Expand Down
2 changes: 1 addition & 1 deletion ....repo_name }}/src/{{ cookiecutter.python_package }}/pipelines/data_processing/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def create_pipeline(**kwargs) -> Pipeline:
[
node(
func=load_shuttles_to_csv,
inputs="shuttles@excel",
inputs="shuttles_excel",
outputs="shuttles@csv",
name="load_shuttles_to_csv_node",
),
Expand Down
2 changes: 1 addition & 1 deletion spaceflights-pyspark/{{ cookiecutter.repo_name }}/conf/base/catalog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ reviews:
header: True
mode: overwrite

shuttles@excel:
shuttles_excel:
type: pandas.ExcelDataset
filepath: data/01_raw/shuttles.xlsx

Expand Down
3 changes: 2 additions & 1 deletion spaceflights-pyspark/{{ cookiecutter.repo_name }}/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ ipython>=8.10
jupyterlab>=3.0
notebook
kedro~={{ cookiecutter.kedro_version }}
kedro-datasets[pandas.CSVDataset, pandas.ExcelDataset, pandas.ParquetDataset, spark.SparkDataset]>=1.0
kedro-datasets[pandas-csvdataset, pandas-exceldataset, pandas-parquetdataset, spark-sparkdataset]>=3.0; python_version >= "3.9"
kedro-datasets[pandas.CSVDataset, pandas.ExcelDataset, pandas.ParquetDataset, spark.SparkDataset]>=1.0; python_version < "3.9"
kedro-telemetry>=0.3.1
kedro-viz>=6.7.0
pytest-cov~=3.0
Expand Down
2 changes: 1 addition & 1 deletion ....repo_name }}/src/{{ cookiecutter.python_package }}/pipelines/data_processing/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def create_pipeline(**kwargs) -> Pipeline:
[
node(
func=load_shuttles_to_csv,
inputs="shuttles@excel",
inputs="shuttles_excel",
outputs="shuttles@csv",
name="load_shuttles_to_csv_node",
),
Expand Down
Loading