Update kedro-datasets optional dependencies requirements naming #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lrcouto <[email protected]>
7 tasks
lrcouto
changed the title
|
Tests are expected to fail until the |
10 tasks
…lize-kedro-datasets-naming
…g/kedro-starters into normalize-kedro-datasets-naming
lrcouto
changed the title
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: Merel Theisen <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: lrcouto <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
Signed-off-by: Elena Khaustova <[email protected]>
ElenaKhaustova
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
Tested updated datasets' names
All tests are passing when pointing test branch: kedro-org/kedro@main...debug/point-to-test-starters-branch
Reverted back to point to main branch, so tests failing is expected
merelcht
approved these changes
Apr 15, 2024
| @@ -101,7 +101,7 @@ def before_scenario(context, scenario): | |||
| "install", | |||
| "-U", | |||
| # pip==23.3 breaks dependency resolution | |||
There was a problem hiding this comment.
Is this comment still relevant?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Part of the proposal for kedro-org/kedro-plugins#313. To be merged after
kedro-datasets 3.0.0release. Updates the requirements for starters to use the new naming convention forkedro-datasetsoptional dependencies.Depends on kedro-org/kedro-plugins#570
How has this been tested?
Checklist