Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasets): Add optional dependencies duplication in pyproject.toml #307

Closed
wants to merge 1 commit into from

Conversation

DimedS
Copy link
Member

@DimedS DimedS commented Aug 15, 2023

Description

This PR serves as an interim solution to the issue of nesting with "." in the pyproject.toml file. All lines have been duplicated following this pattern:

"pandas.JSONDataSet" = ["kedro-datasets[pandas-base]"]
"pandas-jsondataset" = ["kedro-datasets[pandas-base]"]

It appears the long-term solution might involve aligning names with the packaging standards, as mentioned by @astrojuanlu in this comment, or transitioning from setuptools to poetry.

Development notes

Manually tested: works well with .[all] and .[spark.SparkDataSet].
It seems we should introduce tests to automate the verification of dependency installations.

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the relevant RELEASE.md file
  • Added tests to cover my changes

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with this approach as long as we are fine with keeping the new extras we're introducing in the long run. In other words: at some point in the future, we settle with the new syntax and tell our users to do pip install kedro-datasets[pandas-csvdataset]. See more context in my comment here #306 (comment)

@DimedS DimedS closed this Aug 17, 2023
@DimedS DimedS deleted the fix/306-kedro-datasets-152-breaks branch August 17, 2023 17:52
@astrojuanlu
Copy link
Member

Closed in favor of #310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kedro-datasets 1.5.2 breaks pip install kedro-datasets[all]
2 participants