-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datasets): Add Support Python 3.11 for kedro-datasets #297
Conversation
weird! latest version is 3.8, and it definitely has precompiled wheels for 3.11 https://pypi.org/project/tables/3.8.0/#files I can't reproduce locally:
you can try adding |
Oh but earlier in the logs we see this:
so, I think pip might be backtracking here because of some incompatibility. Since this is ubuntu-latest, maybe you can do |
…rg/kedro-plugins into bump/python-3.11-support
Welp, there seems to be some incompatibility with the dependencies 😬 After 47 minutes of heavy backtracking, still no solution https://github.com/kedro-org/kedro-plugins/actions/runs/5865409178/job/15902606193?pr=297 I contributed some additional logging to pip that made it to >= 23.1 pypa/pip#10937 and maybe it can help in this situation. My recommendation is to do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SajidAlamQB! ⭐
Fantastic job @SajidAlamQB and team 👏🏽 |
…#297) * Add 3.11 tests to CI * update dependencies * 3.11 should only run on kedro-datasets * update setup matrix * refine setup matrix * use steps * pytables for unix * add pytables via conda * fix indent * add conda * activate windows * undo last commit * remove pytables conda install * Update pyproject.toml * pin pytables 3.8 for python 3.11 * lint * pin sqlalchemy for 3.11 * install gfortran * add pip_verbose and run onlu ubuntu tests * undo gfortran install * Update pyproject.toml * add conda install pytables * remove tables from pyproject.toml * Update pyproject.toml * pin tables 3.6 for unix * Update pyproject.toml * update pyspark * Update check-plugin.yml * change base spark dependency pin 3.4 * fix spark tests * Update test_spark_jdbc_dataset.py * coverage * fix coverage * Fix streaming dataset * fix streaming test * Update test_spark_hive_dataset.py * fix base pin * Remove delta-spark pin Signed-off-by: Nok <[email protected]> * lower pyspark pin for 3.11 * pin delta-spark to 2.4 for python 3.11 * Update conftest.py * revert * Set delta version base on delta-spark version Signed-off-by: Nok <[email protected]> * Update setup.py * open-bound * Update setup.py * scikit pin * Update setup.py * Update pyproject.toml * align with framework setup * Update setup.py * importlib_metadata backport * add deltalake * update holoviews pin * remove miniconda and conda pytables * add windows test back in running all parallel no spark * Update check-plugin.yml * add msbuild and run only windows * Update check-plugin.yml * lint * lint * update pandas pin * replace semver with packaging * lint * lint * add empty stacktrace for AnalysisException * revert * lint with 3.11 * update python version for linting * Remove setup matrix * Update check-plugin.yml * Update check-plugin.yml * overhaul python version and os pass in * Update check-plugin.yml * revert changes * Update check-plugin.yml * rtd with 3.8 * add snowflake-snowpark * remove repeated * release notes --------- Signed-off-by: Nok <[email protected]> Co-authored-by: Nok Lam Chan <[email protected]>
Description
Add Python 3.11 support for Kedro-datasets
Development notes
plugin == kedro-datasets
and adds3.11
to the setup matrix if it does. This helps unit tests to run on python3.11
only forkedro-datasets
.Checklist
RELEASE.md
file