Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow maxReplicaCount > number of partition for Kafka scaler for Scaling Jobs #1806

Closed
iferca opened this issue May 15, 2021 · 2 comments
Closed
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@iferca
Copy link

iferca commented May 15, 2021

Proposal

Configure maxReplicaCount bigger than partition count in a topic for a scaling job with Kafka trigger resulting in effectively having more jobs running than partitions in the topic.

Use-Case

I use Kafka as a trigger for long-running jobs. These jobs read a message, perform an action, and complete. At the moment I'm limited to have as many jobs as partitions. even when jobs consume the message and close the consumer to perform the actual operations. Once the message is consumed, committed, and the consumer closed -I can verify that for a given consumer group there is no consumer registered in confluent cloud-, I cannot trigger any more jobs if running jobs are equal to the partition count.
Allowing scaler limit to be maxReplicaCount, even when maxReplicacount > topic partition count will enable me to use even a single partition topic to trigger many jobs, lmited only by how fast the job consumes the message and commits it.

Anything else?

I acknowledge the risk of expecting more consumers than partitions and I value the safe defaults and I think those are the way to go. The more advanced use cases should also be allowed, with propper documentation, so the safe defaults won't become a limitation for the tool.
I'm now forced to have a bigger cluster than otherwise needed because I have many topics orchestrating a multi-stage pipeline of "step functions" and so I can have the number of stages that are required I'm forced to have large partitions count.

@iferca iferca added feature-request All issues for new features that have not been committed to needs-discussion labels May 15, 2021
@tomkerkhove
Copy link
Member

This seems similar to #1683 which is coming in v2.3 (PR), can you check if this is what you need please?

@iferca
Copy link
Author

iferca commented May 19, 2021

Totally! Awesome then. closing this.

@iferca iferca closed this as completed May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
None yet
Development

No branches or pull requests

2 participants