From 8f3e0d6a606880207a7e161449f0d7ac17a72316 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adam=20Neto=C4=8Dn=C3=BD?= Date: Tue, 16 Jan 2024 18:51:02 +0100 Subject: [PATCH] fix(github-runner-scaler) Add support for key authentication against GHES (#5384) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Adam Netočný --- CHANGELOG.md | 1 + pkg/scalers/github_runner_scaler.go | 1 + 2 files changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 857a7d5ad1a..349732bbdcf 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -136,6 +136,7 @@ Here is an overview of all new **experimental** features: - **Azure Pipelines**: No more HTTP 400 errors produced by poolName with spaces ([#5107](https://github.com/kedacore/keda/issues/5107)) - **GCP pubsub scaler**: Added `project_id` to filter for metrics queries ([#5256](https://github.com/kedacore/keda/issues/5256)) - **GCP pubsub scaler**: Missing use of default value of `value` added ([#5093](https://github.com/kedacore/keda/issues/5093)) +- **Github Runner Scaler**: github-runner-scaler is unable to work with custom API endpoint ([#5387](https://github.com/kedacore/keda/issues/5387)) - **NATS JetSteam Scaler**: Raise an error if leader not found ([#5358](https://github.com/kedacore/keda/pull/5358)) - **Pulsar scaler**: Fix panic when auth is not used ([#5271](https://github.com/kedacore/keda/issues/5271)) - **ScaledJobs**: Copy ScaledJob annotations to child Jobs ([#4594](https://github.com/kedacore/keda/issues/4594)) diff --git a/pkg/scalers/github_runner_scaler.go b/pkg/scalers/github_runner_scaler.go index ef36292627f..d9c30c0d622 100644 --- a/pkg/scalers/github_runner_scaler.go +++ b/pkg/scalers/github_runner_scaler.go @@ -345,6 +345,7 @@ func NewGitHubRunnerScaler(config *scalersconfig.ScalerConfig) (Scaler, error) { if err != nil { return nil, fmt.Errorf("error creating GitHub App client: %w, \n appID: %d, instID: %d", err, meta.applicationID, meta.installationID) } + hc.BaseURL = meta.githubAPIURL httpClient = &http.Client{Transport: hc} }