fix: trailing open block comment #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odinuv
approved these changes
Feb 12, 2019
| @@ -3,7 +3,5 @@ php: | |||
| - 5.6 | |||
| - 5.5 | |||
| - 5.4 | |||
| - 5.3 | |||
There was a problem hiding this comment.
tak to muzes rovnou vyhodit aji tu 5.4 a 5.5 ne?
There was a problem hiding this comment.
👍 bohužel 7.0+ nešlape a to teď vůbec nechci řešit
| @@ -214,7 +214,7 @@ protected static function getNextToken($string, $previous = null) | |||
| } | |||
|
|
|||
| // Comment | |||
| if ($string[0] === '#' || (isset($string[1])&&($string[0]==='-'&&$string[1]==='-') || ($string[0]==='/'&&$string[1]==='*'))) { | |||
| if ($string[0] === '#' || (isset($string[1])&&($string[0]==='-'&&$string[1]==='-') || ($string[0]==='/'&&isset($string[1])&&$string[1]==='*'))) { | |||
There was a problem hiding this comment.
chtěl jsem držet aktuální coding style. kdybychom tu knihovnu adoptovali, tak bych to doladil, ale do tý doby se snažím zdržet coding style změn.
There was a problem hiding this comment.
no tak mas tam $string[0] === '#' a hned vedle $string[0]==='-' tak nevim co to je za coding style :) krome random
There was a problem hiding this comment.
jj, ale to jsem neměnil, přidával jsem jen isset($string[1])&& do poslední části podmínky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following query fails with
Notice: Uninitialized string offset: 1