Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.storeAll now stores processed images for locals too, as it should be #810

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

.storeAll now stores processed images for locals too, as it should be #810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Sources/Nuke/Tasks/TaskLoadImage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,7 @@ final class TaskLoadImage: AsyncPipelineTask<ImageResponse>, @unchecked Sendable

private func shouldStoreResponseInDataCache(_ response: ImageResponse) -> Bool {
guard !response.container.isPreview,
!(response.cacheType == .disk),
!(request.url?.isLocalResource ?? false) else {
!(response.cacheType == .disk) else {
return false
}
let isProcessed = !request.processors.isEmpty || request.thumbnail != nil
Expand Down
Loading