Add visionOS support

[theedov]

[barnard-b]

There are two build errors for visionOS: This one in Graphics.swift and another in ImageDecoders+Video.swift

As a temporary solution you can open those files in Visual Studio Code and edit them (you will need to select overwrite when saving). To be clear, this is only a temporary solution and the scale value is just a guess, but it should allow it to compile.

struct Screen {
    #if os(xrOS)
    /// 2 is just a guess, do not depend on it.
    static var scale: CGFloat { 2 }
    #elseif os(iOS) || os(tvOS)
    /// Returns the current screen scale.
    static var scale: CGFloat { UIScreen.main.scale }
    #elseif os(watchOS)
    /// Returns the current screen scale.
    static var scale: CGFloat { WKInterfaceDevice.current().screenScale }
    #elseif os(macOS)
    /// Always returns 1.
    static var scale: CGFloat { 1 }
    #endif
}

(UIScreen is not available in xrOS)

private func makePreview(for data: Data) -> PlatformImage? {
    #if os(xrOS)
    return nil
    #else
    let asset = AVDataAsset(data: data)
    let generator = AVAssetImageGenerator(asset: asset)
    guard let cgImage = try? generator.copyCGImage(at: CMTime(value: 0, timescale: 1), actualTime: nil) else {
        return nil
    }
    return PlatformImage(cgImage: cgImage)
    #endif
}

(copyCGImage is not available in xrOS)

[kean]

I wonder if there is a way to ship it without introducing warnings on Xcode 14.

I'll create a branch for now.

[theedov]

They might even change it to visionOS in the upcoming betas.

[kean]

Do you know if SPM is supported? I can't get the package manifest to compile after adding .xrOS(.v1) – doesn't recognize it.

[kean]

Preliminary xrOS support is now available in xcode-15 branch.

• PR: Xcode 15 and xrOS Support #707
• Version: https://github.com/kean/Nuke/releases/tag/12.2.0-beta.1

[frlefebvre]

The last Xcode beta seems to have introduced a few more issues. At first glance, they seem to mostly be due to using AppKit instead of UIKit. Like here:

[drmarkpowell]

Just putting it out there that the prompt attention you are giving this issue encouraged me to become a sponsor! Keep up the great work :) Looking forward to using Nuke in my visionOS app soon.

[kean]

I appreciate it, @drmarkpowell. It is in the works. I already have the latest Xcode beta and was planning to push the new pre-release version soon.

[kean]

Version 12.2 (Beta 2) fixes the new compilation errors in Xcode 15 Beta 6.

The plan for the future version is to remove as many of the #if os(...) checks as possible and replace them with #if canImport(...).

I'm yet to figure out how to add SPM support, especially in a way that won't break Xcode 14 compatibility. Any information on that is welcome.