Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel/Systemmatic enums #33

Open
dteague opened this issue Feb 27, 2020 · 0 comments
Open

Channel/Systemmatic enums #33

dteague opened this issue Feb 27, 2020 · 0 comments

Comments

@dteague
Copy link
Contributor

dteague commented Feb 27, 2020

I started doing this with my open PR (#32 ), but it might be good to expand this to also the chans and systematics. My gripe being that I wish these things were virtual but with enums, you really can't do that. Putting more generic variables and functions in the selectorBase makes sense, but with these ever expanding lists and maps, I think it would be good to switch over to something different for this

I've made the "dynEnum" class to get around this (it's not very sophisticated) to handle this problem. I'm sure there are better solution, so we might want to think about this. Especially since there is the nifty histLabel class you've made to handle adding histograms. I might link to some code snippets if I think of anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant