-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
btrfs-progs: docs: further improve space cache documentation #620
Open
calestyo
wants to merge
2
commits into
kdave:devel
Choose a base branch
from
calestyo:further-improve-space-cache-documentation
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
btrfs-progs: docs: further improve space cache documentation #620
calestyo
wants to merge
2
commits into
kdave:devel
from
calestyo:further-improve-space-cache-documentation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For the btrfs check option of clearing, indicate that - since it's actually a full removing - a new space cache may be generated on the next mount. - In the summary of the `clear_cache` mount option, don't mention that it rebuilds the cache, as the option itself is in principle only about the clearing and the rebuilding happens "automatically" (unless other options are used). - In the details mention, however that there is rebuilding unless prevented by mount option. - Remove the "if something has gone wrong", as the mount option would also remove the cache if nothing went wrong. Signed-off-by: Christoph Anton Mitterer <[email protected]>
please wait with this one... there's more to come |
Strcturise the details more clearly by: - What it does/implications. - The different versions an their details. - What happens if both versions are present. - What happens with kernels that cannot use v2. - How each version can be disabled, cleared or removed. - Make it more clear that the default of "space cache v2" applies also if the option isn't given at all. Signed-off-by: Christoph Anton Mitterer <[email protected]>
calestyo
force-pushed
the
further-improve-space-cache-documentation
branch
from
April 27, 2023 00:59
e94afc8
to
e8a471c
Compare
Correctly rebased on
Is the old v1 then cleared or (as with |
kdave
force-pushed
the
devel
branch
3 times, most recently
from
May 10, 2023 19:47
af681f4
to
1628b2f
Compare
kdave
force-pushed
the
devel
branch
2 times, most recently
from
May 22, 2023 12:32
a8c6f08
to
34c5de3
Compare
kdave
force-pushed
the
devel
branch
5 times, most recently
from
May 26, 2023 17:53
5e02de0
to
adfc8a9
Compare
kdave
force-pushed
the
devel
branch
2 times, most recently
from
June 15, 2023 10:31
d21d383
to
77988fe
Compare
kdave
force-pushed
the
devel
branch
7 times, most recently
from
August 23, 2023 17:44
ff87660
to
89204e7
Compare
kdave
force-pushed
the
devel
branch
2 times, most recently
from
August 28, 2023 16:05
869b77c
to
76f0670
Compare
kdave
force-pushed
the
devel
branch
4 times, most recently
from
April 19, 2024 23:44
247e2d2
to
208150e
Compare
kdave
force-pushed
the
devel
branch
2 times, most recently
from
May 3, 2024 13:01
0bbf8b9
to
bcb887a
Compare
kdave
force-pushed
the
devel
branch
2 times, most recently
from
June 6, 2024 23:14
87a1129
to
e4d372e
Compare
kdave
force-pushed
the
devel
branch
2 times, most recently
from
June 27, 2024 00:22
ca84db7
to
8e8c554
Compare
kdave
force-pushed
the
devel
branch
3 times, most recently
from
July 17, 2024 02:59
c94327d
to
2ce4219
Compare
kdave
force-pushed
the
devel
branch
5 times, most recently
from
August 19, 2024 22:30
48be42f
to
082ce75
Compare
kdave
force-pushed
the
devel
branch
2 times, most recently
from
September 17, 2024 15:00
f6d1943
to
5ff9f62
Compare
adam900710
force-pushed
the
devel
branch
2 times, most recently
from
November 4, 2024 08:01
b7cd74f
to
66f08f9
Compare
kdave
force-pushed
the
devel
branch
3 times, most recently
from
November 28, 2024 13:41
72c9865
to
164145b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the btrfs check option of clearing, indicate that - since it's actually a full removing - a new space cache may be generated on the next mount.
In the summary of the
clear_cache
mount option, don't mention that it rebuilds the cache, as the option itself is in principle only about the clearing and the rebuilding happens "automatically" (unless other options are used).In the details mention, however that there is rebuilding unless prevented by mount option.
Remove the "if something has gone wrong", as the mount option would also remove the cache if nothing went wrong.