Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when adding a new item image it doesnt fill the whole circle!...how can i fix that? #40

Closed
AmrSayedAhmed opened this issue May 29, 2016 · 12 comments

Comments

@AmrSayedAhmed
Copy link

No description provided.

@kciter
Copy link
Owner

kciter commented Jun 30, 2016

What do you mean?
Do you have any screenshot?

@yigitserin
Copy link
Contributor

I have a similar issue. See this:
ss

Context: I used the same icons with the same method and it worked perfectly fine. However, I needed to make the buttons smaller since it wouldn't fit some device screens. So I made the following changes:

    if UIScreen.mainScreen().bounds.height < 600 {
        fab.itemSpace = 8
        fab.itemSize = 36
        fab.size = 40
    }

However, changing itemSize parameter break the image centering. How do I make sure images stay centered when I change the itemSize?

@kciter
Copy link
Owner

kciter commented Jul 12, 2016

Hello guys.
This issue may be same as Issue 44.
Check it out please. 😄

@yigitserin
Copy link
Contributor

Tried the solution there but didn't worked for me. When I change the itemSize, it does not calculate the center correctly.

kciter added a commit that referenced this issue Jul 14, 2016
kciter added a commit that referenced this issue Jul 14, 2016
@kciter
Copy link
Owner

kciter commented Jul 14, 2016

It really my mistake. I fixed it.

@yigitserin
Copy link
Contributor

Thanks, altough I can't seem to get the latest version from cocoapods. When I do pod search KCFloatingActionButton it shows the latest version is 1.3.4.

@kciter
Copy link
Owner

kciter commented Jul 14, 2016

@yigitserin

$ pod search KCFloatingActionButton

-> KCFloatingActionButton (1.3.6)
   Floating Action Button for iOS
   pod 'KCFloatingActionButton', '~> 1.3.6'
   - Homepage: https://github.com/kciter/KCFloatingActionButton
   - Source:   https://github.com/kciter/KCFloatingActionButton.git
   - Versions: 1.3.6, 1.3.5, 1.3.4, 1.3.3, 1.3.2, 1.3.1, 1.3.0, 1.2.1, 1.2.0, 1.1.9, 1.1.8, 1.1.7, 1.1.6, 1.1.5, 1.1.4, 1.1.3, 1.1.2, 1.1.1, 1.1.0, 1.0.1, 1.0.0 [master repo]

https://github.com/CocoaPods/Specs/blob/master/Specs/KCFloatingActionButton/1.3.6/KCFloatingActionButton.podspec.json
🤔

@allaire
Copy link

allaire commented Jul 15, 2016

This broke fab.buttonImage, now my icon appears out of the fab

@kciter
Copy link
Owner

kciter commented Jul 20, 2016

Hello, @allaire
I've update to version 1.3.7.
Check it out please. 😄

@yigitserin
Copy link
Contributor

It worked for me, thanks! Also had to update my pod repository for new versions to appear.

@kciter
Copy link
Owner

kciter commented Jul 21, 2016

Good :)
This issue is closed.

@kciter kciter closed this as completed Jul 21, 2016
@allaire
Copy link

allaire commented Jul 25, 2016

Worked, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants