From a4e126acb856e53ed1c35a847aa3e0a4cb16c962 Mon Sep 17 00:00:00 2001
From: Chris Robinson <chris.kcat@gmail.com>
Date: Mon, 2 Sep 2024 08:40:24 -0700
Subject: [PATCH] Don't assert for unexpected FX slot IDs

Although they should never happen at this point and would indicate a serious
problem, there's no need to kill the process instead of returning a dummy value
(and the assert wouldn't check in release builds anyway).
---
 al/source.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/al/source.cpp b/al/source.cpp
index 6a94065495..1c44d2eb90 100644
--- a/al/source.cpp
+++ b/al/source.cpp
@@ -4015,7 +4015,9 @@ void ALsource::eax4_translate(const Eax4Props& src, Eax5Props& dst) noexcept
             return EAXPROPERTYID_EAX50_FXSlot2;
         if(src_id == EAXPROPERTYID_EAX40_FXSlot3)
             return EAXPROPERTYID_EAX50_FXSlot3;
-        assert(false && "Unknown active FX slot ID.");
+
+        UNLIKELY
+        ERR("Unexpected active FX slot ID\n");
         return EAX_NULL_GUID;
     };
     const auto src_slots = al::span{src.active_fx_slots.guidActiveFXSlots};