feature(spring-mvc): detect endpoint methods with either protected or package-private visibility #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
murdos
force-pushed
the
fix/spring-package-private-endpoints
branch
2 times, most recently
from
c84ed4a to
0b562b5
Compare
murdos
force-pushed
the
fix/spring-package-private-endpoints
branch
from
0b562b5 to
9755055
Compare
|
Requires #168 |
murdos
force-pushed
the
fix/spring-package-private-endpoints
branch
from
9755055 to
dae4b22
Compare
kbuntrock
approved these changes
Oct 2, 2024
| @@ -39,20 +37,6 @@ public static ClassLoader getProjectClassLoader() { | |||
| return ReflectionsUtils.projectClassLoader; | |||
| } | |||
|
|
|||
| public static ConfigurationBuilder createConfigurationBuilder() { | |||
There was a problem hiding this comment.
I like this! the "testMode" boolean is not needed anymore now, I will remove it.
| @@ -698,6 +701,14 @@ public void collection() throws MojoFailureException, IOException, MojoExecution | |||
| checkGenerationResult("ut/SpringClassAnalyserTest/collection.yml", generated.get(0)); | |||
| } | |||
|
|
|||
| @Test | |||
| public void package_private() throws MojoFailureException, IOException, MojoExecutionException { | |||
There was a problem hiding this comment.
perfect, tests are a must have! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This methods are valid Spring endpoints, so they should be correctly detected