Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API update with changed models #4

Open
kevinpapst opened this issue Jul 17, 2020 · 0 comments
Open

API update with changed models #4

kevinpapst opened this issue Jul 17, 2020 · 0 comments

Comments

@kevinpapst
Copy link

Hi!

I had to refactor the Kimai API and smooth out some details.

At least some of your models are now outdated in (eg. all the duplicate ones with numbers at the end, Team1 Team2 ):
https://github.com/kbancerz/kimai-python/tree/master/kimai_python/models

Please have a look at kimai/kimai#1826 and run some test, especially on the routes that have deeper nested objects. I gave my best to avoid BC breaks in the JSON result, but I changed a lot within the serialization layer and unfortunately not every attribute was covered with tests before (now they are).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant