Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-ascii translation key #436

Merged
merged 1 commit into from
Oct 13, 2018
Merged

Conversation

exoego
Copy link
Collaborator

@exoego exoego commented Oct 12, 2018

Closes #363, #398 and #430

I am a little suprised that the change in getPathCharType does not break the existing tests.
I hope code owners to review PR very carefully and give me a guidance.

@codecov-io
Copy link

codecov-io commented Oct 12, 2018

Codecov Report

Merging #436 into dev will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #436      +/-   ##
==========================================
- Coverage   95.91%   95.89%   -0.02%     
==========================================
  Files           9        9              
  Lines         637      634       -3     
==========================================
- Hits          611      608       -3     
  Misses         26       26
Impacted Files Coverage Δ
src/path.js 87.61% <100%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d45d86...9200ec1. Read the comment docs.

@exoego exoego changed the title Allow non-ascii key including numbers. Allow non-ascii translation key Oct 12, 2018
Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WoW!
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants