Add constructor option for custom modifiers #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #724 +/- ##
==========================================
+ Coverage 96.25% 96.26% +0.01%
==========================================
Files 10 10
Lines 800 803 +3
==========================================
+ Hits 770 773 +3
Misses 30 30
Continue to review full report at Codecov.
|
|
Great enhancement 👍 |
kazupon
requested changes
Oct 6, 2019
|
I added documentation for English. I hope I did it correctly, as I found some documentation under vuepress and some under gitbook. Is the second one still maintained? Unfortunately I can't do the Chinese translations 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to pass custom modifiers when creating a i18n object. It extends the functionality of #467 and the
loweranduppermodifiers (also called also formatters previously in the code) with whatever the user needs are.My use case is similar to #513, since I need to sometimes capitalize my linked translation. I believe that giving the ability of extending the modifiers is the best way to go, as the need for modifier functions can be endless and doesn't make sense to support everything by default in the library.