fix(index): make silentTranslationWarn work for dates and numbers too #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `silentTranslationWarn` flag only disables warnings for regular translations, which, I think, is not what people would expect from this option. Even when `silentTranslationWarn` is enabled - warning for fallback translations for numbers and dates still occur, completely littering the console. This fix makes all fallback warnings to vanish (including numbers and dates) upon setting the `silentTranslationWarn` flag, while leaving other (non-fallback) warnings intact.
Codecov Report
@@ Coverage Diff @@
## dev #481 +/- ##
=======================================
Coverage 96.64% 96.64%
=======================================
Files 9 9
Lines 655 655
=======================================
Hits 633 633
Misses 22 22
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## dev #481 +/- ##
=======================================
Coverage 96.64% 96.64%
=======================================
Files 9 9
Lines 655 655
=======================================
Hits 633 633
Misses 22 22
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
silentTranslationWarnflag only disables warnings for regular translations, which, I think, is not what people would expect from this option. Even whensilentTranslationWarnis enabled - warnings for fallback translations for numbers and dates still occur, completely littering the console in some cases.This fix makes all fallback warnings to vanish (including numbers and dates) upon setting the
silentTranslationWarnflag, while leaving other (non-fallback) warnings intact.