Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm argument missing from implemented "missing" handler function #453

Closed
ijabit opened this issue Oct 26, 2018 · 1 comment
Closed

vm argument missing from implemented "missing" handler function #453

ijabit opened this issue Oct 26, 2018 · 1 comment
Labels
Type: Bug Bug or Bug fixes

Comments

@ijabit
Copy link

ijabit commented Oct 26, 2018

vue & vue-i18n version

ex: 2.5.17, 8.2.1

Steps to reproduce

Implement the missing function like this:

missing: function (loc: Locale, key: Path, vm?: Vue) {
  console.log(loc, key, vm);
}

What is Expected?

The vm argument should be populated.

What is actually happening?

The vm argument is not populated.

I believe the bug is here:
https://github.com/kazupon/vue-i18n/blob/dev/src/index.js
On line 358: return this._root.t(key, ...values)
It doesn't include the host parameter (which is supposed to get mapped to the vm argument in my function.

@kazupon kazupon added the Type: Bug Bug or Bug fixes label Nov 6, 2018
@kazupon kazupon closed this as completed in dc48099 Nov 6, 2018
@ijabit
Copy link
Author

ijabit commented Nov 6, 2018

@kazupon this fix was released to v8.3.0 right? If so, I updated the package and this bug is still there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Development

No branches or pull requests

2 participants