Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear warning - improve message #393

Closed
ffxsam opened this issue Jul 11, 2018 · 7 comments
Closed

Unclear warning - improve message #393

ffxsam opened this issue Jul 11, 2018 · 7 comments

Comments

@ffxsam
Copy link

ffxsam commented Jul 11, 2018

vue & vue-i18n version

2.5.16, 8.0.0

I'm seeing this confusing warning message:

[vue-i18n] not exist VueI18n instance in Vue instance

It would be nice to clean up this language a bit so it makes sense. I have no idea what to do with this warning.

Thanks!

@kimuraz
Copy link
Contributor

kimuraz commented Jul 14, 2018

@kazupon on

warn('not exist VueI18n instance in Vue instance');

and few others similar cases, may I suggest to change it to something like:
[vue-i18n] VueI18n instance does not exists in Vue instance
Just a suggestion, but I can come up with a PR for this, if you want 👍

@ffxsam
Copy link
Author

ffxsam commented Jul 14, 2018

It essentially means $i18n can't be found on the Vue root, correct? It might be good to just say that exactly.

So, I'm getting this warning when I navigate via Vue Router. Not really sure why.

@kazupon
Copy link
Owner

kazupon commented Jul 14, 2018

Sorry late for my response. 🙇
Could you provide the minimum reproduction (with codesandbox or github repo, etc...) codes please?

@kimuraz
Copy link
Contributor

kimuraz commented Jul 16, 2018

@ffxsam So, there are two different things here, right? One is the warning being thrown when navigating via Vue Router (this need repro) and another thing is that you found the current warning message unclear, am I right?

@ffxsam
Copy link
Author

ffxsam commented Jul 19, 2018

Correct. I'll file a separate issue about the strange warnings.

@kimuraz
Copy link
Contributor

kimuraz commented Jul 20, 2018

@kazupon do thinks it's necessary to change the current warning messages? If so, I can handle it :)

@kazupon
Copy link
Owner

kazupon commented Jul 21, 2018

@kimuraz
Yeah, it's neccessary to change due to not clear.
Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants