Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes global auto installation #291

Merged
merged 1 commit into from
Feb 1, 2018

Conversation

emileber
Copy link
Contributor

Fixes #290

@codecov-io
Copy link

codecov-io commented Jan 31, 2018

Codecov Report

Merging #291 into dev will decrease coverage by 0.15%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #291      +/-   ##
==========================================
- Coverage   96.11%   95.95%   -0.16%     
==========================================
  Files           9        9              
  Lines         617      618       +1     
==========================================
  Hits          593      593              
- Misses         24       25       +1
Impacted Files Coverage Δ
src/index.js 99.12% <50%> (-0.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc4f65...69c69d7. Read the comment docs.

@emileber
Copy link
Contributor Author

emileber commented Jan 31, 2018

There was no test to check if the global installation worked, and even Vuex doesn't test this. So I didn't added one.

Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants