Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(extend) Fix this not found #259 #260

Merged
merged 2 commits into from
Dec 14, 2017
Merged

bug(extend) Fix this not found #259 #260

merged 2 commits into from
Dec 14, 2017

Conversation

lzxb
Copy link
Contributor

@lzxb lzxb commented Nov 27, 2017

Fix(#259)

kazupon
kazupon requested changes Dec 12, 2017
View reviewed changes
Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!
Sorry for late reply ... 🙇

Could you add the test please?

@lzxb
Copy link
Contributor Author

lzxb commented Dec 13, 2017

Yes, later

@kazupon
Copy link
Owner

kazupon commented Dec 14, 2017

Thanks!

@kazupon kazupon merged commit c29007e into kazupon:dev Dec 14, 2017
@kazupon kazupon mentioned this pull request Dec 25, 2017
Closed
@lakb248 lakb248 mentioned this pull request Jun 19, 2018
Closed
kazupon added a commit that referenced this pull request Jun 22, 2018
@kazupon
💥 breaking(extend): fix this context binding
aa0e831 
closes #306
closes #286
closes #260

NOTE:
  revert #260 issue, back to revert.
@kazupon kazupon mentioned this pull request Jun 22, 2018
Closed
qkdreyer added a commit to qkdreyer/vue-i18n that referenced this pull request Jul 2, 2018
@qkdreyer
Fixed changelog
a6db428 
kazupon#260 was referenced twice, but this is fixing kazupon#259 and reverting kazupon#260
@qkdreyer qkdreyer mentioned this pull request Jul 2, 2018
Merged
kazupon pushed a commit that referenced this pull request Jul 3, 2018
@qkdreyer @kazupon
📝 docs(changelog): fixed changelog (#383) by @qkdreyer
e87e64b 
#260 was referenced twice, but this is fixing #259 and reverting #260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lzxb @kazupon