Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(fallback): dynamic fallback via missing() #256

Merged
merged 2 commits into from
Mar 13, 2018
Merged

Conversation

houd1ni
Copy link
Contributor

@houd1ni houd1ni commented Nov 23, 2017

Hello!

I like Vue and appreciate your work!
I faced some problem and think, that the change could be very helpful.

Missing() can produce some dynamic results, using it's own fallback algorithm and make something like 'header.nav.toHome' -> 'To Home' transformation e.g.

It's would be also interesting to make it async, but it seems that it's a little bit deeper change.

Missing() can produce some dynamic results, using it's own fallback algorythm and make something like 'header.nav.toHome' -> 'To Home' transformation e.g. It's would be interesting to make it async, but it seems that it's a little bit deeper change.
@houd1ni
Copy link
Contributor Author

houd1ni commented Nov 23, 2017

Also I don't know why CI cannot find eslint, but it all have passed on local machine.

@houd1ni houd1ni changed the title feature(fallback): dynamyc fallback via missing() feature(fallback): dynamic fallback via missing() Nov 24, 2017
Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!
Sorry for late reply ... 🙇

Could you add the test please?

@houd1ni
Copy link
Contributor Author

houd1ni commented Dec 12, 2017

Sure!

@kazupon kazupon merged commit 9fbe467 into kazupon:dev Mar 13, 2018
@kazupon kazupon mentioned this pull request Mar 13, 2018
@houd1ni
Copy link
Contributor Author

houd1ni commented Mar 14, 2018

Is there a test for this? I'm still going to make it 🐌

@kazupon
Copy link
Owner

kazupon commented Mar 14, 2018

4fac87a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants