Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List formatting refactor and places/place feature #218

Merged
merged 5 commits into from
Aug 28, 2017
Merged

List formatting refactor and places/place feature #218

merged 5 commits into from
Aug 28, 2017

Conversation

myst729
Copy link
Contributor

@myst729 myst729 commented Aug 26, 2017

  1. Enable compiling array-like object with list tokens.
  2. Implement places/place prop feature.
  3. Add test cases to cover the changes.
  4. Add docs.

Item 2 depends on item 1, combined in one PR but separate commits.
Commits were rebased so they comes after the codecov report.

@codecov-io
Copy link

codecov-io commented Aug 27, 2017

Codecov Report

Merging #218 into dev will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #218      +/-   ##
==========================================
+ Coverage   96.89%   96.92%   +0.02%     
==========================================
  Files           8        8              
  Lines         547      552       +5     
==========================================
+ Hits          530      535       +5     
  Misses         17       17
Impacted Files Coverage Δ
src/index.js 99.56% <100%> (-0.02%) ⬇️
src/format.js 100% <100%> (ø) ⬆️
src/component.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf4c0a...8d3408f. Read the comment docs.

@myst729
Copy link
Contributor Author

myst729 commented Aug 27, 2017

Oops, I guess it's done now.

Copy link
Owner

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!
Perfect! 💯
Thanks!

@myst729
Copy link
Contributor Author

myst729 commented Aug 28, 2017

This PR should also close #213 and #214 ㊗️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants