bug: bug(mixin): fix SSR memory leak by moving subscribeDataChanging …

…calls into beforeMount (#572) by @Pindar Signed-off-by: Simon Dittlmann <[email protected]>
kazupon · Apr 30, 2019 · 32b5795 · 32b5795
1 parent 48e3500
commit 32b5795
Showing 1 changed file with 24 additions and 6 deletions.
diff --git a/src/mixin.js b/src/mixin.js
@@ -28,8 +28,6 @@ export default {
         }
         this._i18n = options.i18n
         this._i18nWatcher = this._i18n.watchI18nData()
-        this._i18n.subscribeDataChanging(this)
-        this._subscribing = true
       } else if (isPlainObject(options.i18n)) {
         // component local i18n
         if (this.$root && this.$root.$i18n && this.$root.$i18n instanceof VueI18n) {
@@ -59,8 +57,6 @@ export default {
 
         this._i18n = new VueI18n(options.i18n)
         this._i18nWatcher = this._i18n.watchI18nData()
-        this._i18n.subscribeDataChanging(this)
-        this._subscribing = true
 
         if (options.i18n.sync === undefined || !!options.i18n.sync) {
           this._localeWatcher = this.$i18n.watchLocale()
@@ -73,11 +69,33 @@ export default {
     } else if (this.$root && this.$root.$i18n && this.$root.$i18n instanceof VueI18n) {
       // root i18n
       this._i18n = this.$root.$i18n
-      this._i18n.subscribeDataChanging(this)
-      this._subscribing = true
     } else if (options.parent && options.parent.$i18n && options.parent.$i18n instanceof VueI18n) {
       // parent i18n
       this._i18n = options.parent.$i18n
+    }
+  },
+
+  beforeMount (): void {
+    const options: any = this.$options
+    options.i18n = options.i18n || (options.__i18n ? {} : null)
+
+    if (options.i18n) {
+      if (options.i18n instanceof VueI18n) {
+        // init locale messages via custom blocks
+        this._i18n.subscribeDataChanging(this)
+        this._subscribing = true
+      } else if (isPlainObject(options.i18n)) {
+        this._i18n.subscribeDataChanging(this)
+        this._subscribing = true
+      } else {
+        if (process.env.NODE_ENV !== 'production') {
+          warn(`Cannot be interpreted 'i18n' option.`)
+        }
+      }
+    } else if (this.$root && this.$root.$i18n && this.$root.$i18n instanceof VueI18n) {
+      this._i18n.subscribeDataChanging(this)
+      this._subscribing = true
+    } else if (options.parent && options.parent.$i18n && options.parent.$i18n instanceof VueI18n) {
       this._i18n.subscribeDataChanging(this)
       this._subscribing = true
     }