⚡ improvement(index): fix mergeLocaleMessage. add changes notificatio…

…n on merging with an empty target object (#752) by @jekill
kazupon · Dec 18, 2019 · 048eac5 · 048eac5
1 parent c226fc3
commit 048eac5
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -612,7 +612,7 @@ export default class VueI18n {
       this._checkLocaleMessage(locale, this._warnHtmlInMessage, message)
       if (this._warnHtmlInMessage === 'error') { return }
     }
-    this._vm.$set(this._vm.messages, locale, merge(this._vm.messages[locale] || {}, message))
+    this._vm.$set(this._vm.messages, locale, merge({}, this._vm.messages[locale] || {}, message))
   }
 
   getDateTimeFormat (locale: Locale): DateTimeFormat {

diff --git a/test/unit/message.test.js b/test/unit/message.test.js
@@ -79,4 +79,20 @@ describe('message', () => {
       assert.deepEqual({ foo: 'bar', bar: 'foo' }, i18n.getLocaleMessage('en'))
     })
   })
+
+  it('Should be merged and notified if the target is empty', (done) => {
+    const i18n = new VueI18n({
+      locale: 'ru',
+      messages: {
+        ru: {}
+      }
+    })
+    const uw = i18n._vm.$watch('messages.ru.foo', (newVal, oldVal, o) => {
+      assert.equal(newVal, 'бар');
+      uw();
+      done();
+    });
+    i18n.mergeLocaleMessage('ru', { foo: 'бар' })
+    assert.deepEqual({ foo: 'бар' }, i18n.getLocaleMessage('ru'))
+  })
 })