Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No raw text ignore nodes/pattern/text #31

Merged
merged 1 commit into from
Oct 2, 2019

Conversation

stevelacey
Copy link
Contributor

@stevelacey stevelacey commented Sep 30, 2019

Allows node, pattern and text based ignores on the no-raw-text rule

'vue-i18n/no-raw-text': ['warn', {
  ignoreNodes: ['md-icon', 'v-icon'],
  ignorePattern: '^[-#:()&]+$',
  ignoreText: ['EUR', 'HKD', 'USD'],
}]

#27

Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!
I'm glad to your PR. :)

We need unit tests to verify that your PR works correctly.
Could you add unit tests, please? 🙏

@stevelacey
Copy link
Contributor Author

@kazupon done 🚀

@stevelacey stevelacey requested a review from kazupon October 1, 2019 06:08
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great works! 💯
Thanks!

@kazupon
Copy link
Member

kazupon commented Oct 1, 2019

Ah, I have one more request. 🙏
Could you update the docs, please?
https://github.com/kazupon/eslint-plugin-vue-i18n/blob/master/docs/rules/no-raw-text.md

@stevelacey stevelacey force-pushed the no-raw-test-ignores branch from bd529e5 to c4e5b0a Compare October 2, 2019 10:05
@stevelacey
Copy link
Contributor Author

@kazupon bam

@stevelacey stevelacey changed the title No raw text ignore nodes/pattern No raw text ignore nodes/pattern/text Oct 2, 2019
@kazupon
Copy link
Member

kazupon commented Oct 2, 2019

Thanks!

@kazupon kazupon merged commit 34b7a25 into intlify:master Oct 2, 2019
@pr-triage pr-triage bot added the PR: merged label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants