Skip to content

Commit

Permalink
disallow , as a delimiter
Browse files Browse the repository at this point in the history
  • Loading branch information
kazeburo committed Sep 27, 2016
1 parent 86b7f65 commit b923892
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/Cookie/Baker.pm
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ sub pp_crush_cookie {
my $cookie_string = shift;
return {} unless $cookie_string;
my %results;
my @pairs = grep m/=/, split "[;,] ?", $cookie_string;
my @pairs = grep m/=/, split "; ?", $cookie_string;

This comment has been minimized.

Copy link
@miyagawa

miyagawa Sep 29, 2016

were there any reason to avoid using // in split's first argument?

This comment has been minimized.

Copy link
@kazeburo

kazeburo Sep 29, 2016

Author Owner

no reason. just copied from Plack::Request.

This comment has been minimized.

Copy link
@kazeburo

kazeburo Sep 29, 2016

Author Owner

fixed 127544a

for my $pair ( @pairs ) {
# trim leading trailing whitespace
$pair =~ s/^\s+//; $pair =~ s/\s+$//;
Expand Down

1 comment on commit b923892

@cho45
Copy link

@cho45 cho45 commented on b923892 Jul 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want new version with this commit.

Please sign in to comment.