Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fmtverbs in resource names #67

Merged
merged 5 commits into from
Aug 9, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Aug 8, 2022

Adds support for format verbs in resource names. For example, in https://github.com/hashicorp/terraform-provider-aws/blob/38319aa13aea65d3e946450c1f881d8fef12e734/aws/resource_aws_quicksight_user_test.go#L195-L203

data "aws_caller_identity" "current" {}

resource "aws_quicksight_user" %[1]q {
  aws_account_id = data.aws_caller_identity.current.account_id
  user_name      = %[1]q
  email          = %[2]q
  identity_type  = "QUICKSIGHT"
  user_role      = "READER"
}

Closes #48

Also handles provider meta-argument.

Copy link
Owner

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎩

@katbyte katbyte merged commit c663757 into katbyte:main Aug 9, 2022
@katbyte katbyte added this to the v0.5.0 milestone Aug 9, 2022
katbyte added a commit that referenced this pull request Aug 9, 2022
@gdavison gdavison deleted the support-fmtverbs-in-resource-name branch August 9, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format verbs used as resource names not replaced
2 participants