Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add controller builder options and funcs #461

Merged
merged 1 commit into from
Jul 3, 2023
Merged

feat: add controller builder options and funcs #461

merged 1 commit into from
Jul 3, 2023

Conversation

kinsolee
Copy link
Contributor

Changes

add controller builder options and funcs

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • spec PR link included
  • Follows the commit message standard
  • Meets the contributing guidelines (including
    functionality, content, code)
  • Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

@kinsolee kinsolee force-pushed the feat/ctl-builder-optfuncs branch from 32cbd03 to 0cb2233 Compare June 28, 2023 09:14
kinsolee
kinsolee commented Jun 29, 2023
View reviewed changes
controllers/builderfuncs.go Outdated Show resolved Hide resolved
@kinsolee kinsolee force-pushed the feat/ctl-builder-optfuncs branch from 0cb2233 to 959fad5 Compare June 29, 2023 04:04
@kinsolee kinsolee merged commit 85f2924 into main Jul 3, 2023
@kinsolee kinsolee deleted the feat/ctl-builder-optfuncs branch July 3, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanjingfm nanjingfm nanjingfm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kinsolee @nanjingfm