support chinese resource name #244

airycanon · 2022-08-17T03:11:34Z

Changes

support chinese resource name

As the author of this PR, please check off the items in this checklist:

spec PR link included
Follows the commit message standard
Meets the contributing guidelines (including
functionality, content, code)
Test cases with documentation and functionality works as expected using current and related github repos (MUST deploy and check)
Release notes block below has been filled in or deleted (only if no user facing changes)

apis/validation/nameset_test.go

alaudabot · 2022-08-17T03:16:37Z

_{updated at Wed Aug 17 06:45:08 UTC 2022}

Status: OK 🟢

Metric	Change set	Target _(main)	After
🧪 Code coverage	100.00% _{Coverage on 5 new lines}	40.10%	40.10% ↔️ 🟢 _{estimated after merge} _{allowed difference 0}
👥 Duplications	0.00% _{Duplications on 0 new lines}	0.20%	0.20% ↔️ 🟢 _{estimated after merge} _{allowed difference 0}

[244]

airycanon commented Aug 17, 2022

View reviewed changes

apis/validation/nameset_test.go Show resolved Hide resolved

support chinese resource name

579827b

airycanon force-pushed the feat/support-chinese-resource-name branch from 4e8b32c to 579827b Compare August 17, 2022 06:30

danielfbm approved these changes Aug 17, 2022

View reviewed changes

airycanon merged commit 38933dd into main Aug 17, 2022

airycanon deleted the feat/support-chinese-resource-name branch August 17, 2022 08:27