feat: allow rollback ignore not found

katanomi · Oct 31, 2022 · 979ddbe · 979ddbe
1 parent e8f46ed
commit 979ddbe
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/testing/framework/condition.go b/testing/framework/condition.go
@@ -166,6 +166,7 @@ func MustRollback(testCtx *TestContext, obj client.Object, opts ...client.Delete
 	Expect(obj).NotTo(BeNil())
 
 	err := testCtx.Client.Delete(testCtx.Context, obj, opts...)
+	err = client.IgnoreNotFound(err)
 	Expect(err).To(Succeed())
 
 	WaitRollback(testCtx, obj)

diff --git a/testing/framework/condition_test.go b/testing/framework/condition_test.go
@@ -93,4 +93,22 @@ var _ = Describe("TestCondition", func() {
 		})
 	})
 
+	Context("rollback but resouce not found", func() {
+		cm := NewTestConfigMap("aa", "default", nil)
+
+		When("rollback action", func() {
+			It("should rollback successfully", func() {
+				key := types.NamespacedName{
+					Namespace: cm.Namespace,
+					Name:      cm.Name,
+				}
+				newCm := &corev1.ConfigMap{}
+				err := testCtx.Client.Get(testCtx.Context, key, newCm)
+				Expect(errors.IsNotFound(err)).To(BeTrue())
+
+				MustRollback(testCtx, cm)
+			})
+		})
+	})
+
 })