Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

CRI-O tests: outdated conmon version #2271

Closed
haircommander opened this issue Jan 29, 2020 · 3 comments · Fixed by kata-containers/runtime#2425
Closed

CRI-O tests: outdated conmon version #2271

haircommander opened this issue Jan 29, 2020 · 3 comments · Fixed by kata-containers/runtime#2425
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@haircommander
Copy link
Contributor

Description of problem

in CRI-O, our kata integration tests have been failing in release-1.16 for a while. it turns out we merged a commit that broke backwards compatibility with conmon, and the conmon version used in the kata test is now out of date.

Expected result

kata tests to pass

Actual result

12:21:05 # conmon: option parsing failed: Unknown option --persist-dir

I would submit a PR, but it seems the kata version is managed as an external version. Where is this variable defined and can we update it to (at minimum) 2.0.7?

@haircommander haircommander added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Jan 29, 2020
@haircommander
Copy link
Contributor Author

@chavafg PTAL

@chavafg
Copy link
Contributor

chavafg commented Jan 29, 2020

We manage the conmon version here: https://github.com/kata-containers/runtime/blob/master/versions.yaml#L183-L186

we recently got issues with latest version. so we currently stick to v2.0.1. I am not sure if Kata needs to add/change something to support latest version.
/cc @amshinde

For reference:
b145f4c#diff-bf1835c7dd8eb40baff2fda278134cc2

kata-containers/runtime#2352 (comment)

@haircommander
Copy link
Contributor Author

okay, I'm going to open a PR to update the version, and see if I can look into the breakages

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants