Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qc_plot(modules='all') does not check whether the FastQC report has data for that module. #28

Open
JohnMMa opened this issue Aug 3, 2023 · 0 comments · May be fixed by #29
Open

qc_plot(modules='all') does not check whether the FastQC report has data for that module. #28

JohnMMa opened this issue Aug 3, 2023 · 0 comments · May be fixed by #29

Comments

@JohnMMa
Copy link

JohnMMa commented Aug 3, 2023

After FastQC version 0.11.6, kmer content is no longer being reported, see https://github.com/s-andrews/FastQC/releases/tag/v0.11.6. However, when we run qc_plot with modules='all', the results from .valid_fastqc_modules(modules='all') will still contain ("Kmer Content", despite qc$summary no longer having an entry for it. This means, the plot.func(qc, status = status) step will throw an error when modules reach "kmer_content", owing to status = NA.

qc_plot should including checking for the output .valid_fastqc_modules(modules='all') on whether qc has data for the module(s) selected. A PR is nearly ready and will be submitted within today.

The attached 5k_pbmc_protein_v3_nextgem_gex_S1_L001_R1_001_fastqc.zip is an example from this; it's generated by running fastqc version 0.12.1 with default parameters on one of the FASTQ files from the 10X Genomics 5k_pbmc_protein_v3_nextgem data set.

@JohnMMa JohnMMa linked a pull request Aug 3, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant